Autoformat Fighting eslint Rules

#1

Folks, since rebasing on https://github.com/eclipse-theia/theia/commit/1ca3ec37c079a6b316278cf292609653e57b8151 , I cannot edit the file callhierarchy-tree-widget.tsx anymore. The formatter (runs on save, even though I’ve turned that off int the preferences???) insists on formatting

    this.editorManager.open(
        new URI(uri), {
        mode: keepFocus ? 'reveal' : 'activate',
        selection: range
    }
    ).then(editorWidget => {

but eslint wants

    this.editorManager.open(
        new URI(uri), {
            mode: keepFocus ? 'reveal' : 'activate',
            selection: range
        }
    ).then(editorWidget => {

Can someone advise, please? @paul-marechal ?

[original thread by Thomas Mäder]

#2

Ok, two solutions:

this.editorManager.open(
    new URI(location.uri),
    {
        mode: keepFocus ? 'reveal' : 'activate',
        selection: Range.create(location.range.start, location.range.end)
    }
).then(editorWidget => {

Or we disable the indent rule because I don’t know what VS Code formatter to use that wouldn’t fight ESLint… That specific rule was automatically generated when I converted the tslint configs, but we can always remove it.

@anton-kosyakov thoughts?

#3

Also, we apparently would have to use prettier with eslint?

#4

prettier is not necessary, we should adjust eslint to follow typescript extension formatter

#5

i really don’t want another very opinionated tool

#6

default formatter from typescript extension is good, if eslint disagree with it then just silent it

#7

it would be good to enable auto formatting on save for VS Code and Theia that all code gets reformatted incrementally

#8

@tsmaeder just disable this eslint rule and use typescript extension formatting