File explorer context menu and global selection

#1

When a node in file explorer is selected and there is a difference click event handling with regard to global selection.

  • On click - global selection is updated

  • On context menu - global selection is not updated (it would be updated if the node is not selected before)

Is this difference in behavior intentional?

[original thread by amiramw]

#2

for me it is updated, it would be a bug if is not, since context menu will be built based on bogus context?

#3

[amiramw]

I also think it is a bug. It happens to me on theia master. My test is to put a breakpoint on selection-service.ts on selection setter

#4

[amiramw]

click on selected node in the tree stops in this breakpoint

#5

[amiramw]

right click on selected node in the tree doesn’t stop there

#6

[amiramw]

do you see this behavior?

#7

Could you file an issue i will try to verify tomorrow?

#8

[amiramw]

#9

[amiramw]

#10

ok, thanks, I hope Akos will find to have a look at it, he wrote this part