/********************************************************************************
* Copyright (C) 2017 TypeFox and others.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0 which is available at
* http://www.eclipse.org/legal/epl-2.0.
*
* This Source Code may also be made available under the following Secondary
* Licenses when the conditions for such availability set forth in the Eclipse
* Public License v. 2.0 are satisfied: GNU General Public License, version 2
* with the GNU Classpath Exception which is available at
* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
********************************************************************************/
import * as mv from 'mv';
import * as trash from 'trash';
import * as paths from 'path';
import * as fs from 'fs-extra';
show original
In this file, it is found FileSystemNodeOptions.moveToTrash type is true and default value is also true. Should the type declaration use boolean instead of true?
@injectable ()
export class FileSystemNodeOptions {
encoding: string;
recursive: boolean;
overwrite: boolean;
moveToTrash: true;
public static DEFAULT: FileSystemNodeOptions = {
encoding: 'utf8',
overwrite: false,
recursive: true,
moveToTrash: true
};
}
[original thread by Jacky Deng]
Makes sense to me, although for this kind of issue, you can definitely open an issue on the GitHub tracker.
[Jacky Deng]
OK. Just to confirm this is a real bug. Filed issue: https://github.com/theia-ide/theia/issues/3893
Paul, if it is ok, you can assign the issue to me and I will fix it soon.