!important keyword in css for opacity in :focus

Hello. You are using !important keyword in css styling for :focus elements. This is bad design, because users cannot override this property without using !important keyword. Css can be found here: node_modules@theia\core\src\browser\style\index.css line 149. Will you fix this?

@MoHcmp thank you for the discussion!

will you fix this?

Please go ahead and submit a pull-request to update the css if interested :+1:

I don’t know if removing !important keyword will break something. How can i check if everything is ok after removing this keyword from css?

I don’t know if removing !important keyword will break something. How can i check if everything is ok after removing this keyword from css?

You’ll need to confirm that the styling is consistent, and that if !important is removed that the existing or new css selector is specific enough to still work. Looking at the code there are quite a few instances where !important is used, so I’m not sure which one you want to update specifically but you’ll need to ensure it is still styled correctly for that element.