macOS File Options disables

kaustav-aarish · 21 February 2021 17:55

eclipse-theia/theia/blob/master/packages/workspace/src/browser/workspace-frontend-contribution.ts

/********************************************************************************
 * Copyright (C) 2017 TypeFox and others.
 *
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License v. 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0.
 *
 * This Source Code may also be made available under the following Secondary
 * Licenses when the conditions for such availability set forth in the Eclipse
 * Public License v. 2.0 are satisfied: GNU General Public License, version 2
 * with the GNU Classpath Exception which is available at
 * https://www.gnu.org/software/classpath/license.html.
 *
 * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
 ********************************************************************************/

import { injectable, inject } from 'inversify';
import { CommandContribution, CommandRegistry, MenuContribution, MenuModelRegistry, SelectionService } from '@theia/core/lib/common';
import { isOSX, environment, OS } from '@theia/core';
import {

This file has been truncated. show original

Why are file options disabled for macOS? A number of workspace commands have the following: !isOSX && this.isElectron()

Furthermore, is there any way to avoid this (Have also tried menus with no OS checks, FILE_OPEN for example)? We are using the following code to enable a workspace command:

@injectable()
export class ProjectCreatorMenuContribution implements MenuContribution {

    registerMenus(menus: MenuModelRegistry): void {
        menus.registerMenuAction(CommonMenus.FILE_NEW, {
            commandId: ProjectCreateCommand.id,
            label: 'New Project'
        });
    }
}

Thanks for your help!

vince-fugnitto · 22 February 2021 00:28

@kaustav-aarish thanks for the discussion, certain commands were added only in the electron (desktop) applications, while some are only available for certain operating systems in order to align with similar menus found in vscode.

Furthermore, is there any way to avoid this (Have also tried menus with no OS checks, FILE_OPEN for example)? We are using the following code to enable a workspace command:

If you would not like to rebind the whole contribution, you can register a custom command which is enabled/visible based on your requirements and it’s execute callback can simply execute the original command.

For instance:

 registerCommands(commands: CommandRegistry): void {
        // Updated command.
        commands.registerCommand(WorkspaceCommands.OPEN_CUSTOM, {
            isEnabled: () => true,
            isVisible: () => true,
            execute: () => commands.executeCommand(WorkspaceCommands.OPEN)
        });

You can then use your custom commands for menus.

kittaakos · 25 February 2021 17:39

Because you cannot have a native file dialog with both file and folder selectors on Linux and Windows. See here. So we had to make some restrictions.