PR final approval https://github.com/theia-ide/theia/pull/3804

@svenefftinge

since @anton-kosyakov is on PTO is it still possible to get final approval for https://github.com/theia-ide/theia/pull/3804

[original thread by Anatoliy Bazko]

Anton mentioned something along the lines that you should not just rename the components but move them. Not sure what he was referring to exactly, but it was when he was about to leave for holidays. He will be back on January 4.

I would prefer if I don’t need to look into it before Christmas as I have so many other things on my list. Would it be ok to clarify this in the beginning of January?

[Anatoliy Bazko]

I might miss something, which comment are you referring to?

He mentioned that to me in direct conversation when he left the office. Sorry.

Hello, AFAIK Anatolii’s team need debug plug-in support for theia 0.3.18 which is released before end of this year. How can we move forward ?

[Anatoliy Bazko]

I guess they are the same requirements as for https://github.com/theia-ide/theia/pull/3805

[Anatoliy Bazko]

@svenefftinge

Did you mean this one?

Sorry, I went offline being sick yesterday. Will look into it now.

Yes, the second comment about the implicit dependency debug -> plug-in it is. The debug extension should not have anything specific for the plug-in system.

[Anatoliy Bazko]

Get better soon.

I will update PR today then.

I already commented on the PR. If you know what Anton meant please update it. If not we can do the changes after merge, too.

thanks @svenefftinge for your reply. Didn’t know you were sick, so have good recovery !

I’m fine already again. But thank you :slight_smile:

[Anatoliy Bazko]

I’ve fix Anton’s remark.

So I am going to merge the PR. If he have any questions I will fix them ASAP.

[Anatoliy Bazko]

It turned out that front-end plugings stopped working. I am fixing…

[Anatoliy Bazko]

hi, thanks for taking care about it