StatusBar onClick not working

chakraborty-slx · 9 May 2022 06:20

HI ,

I am have custom progress statusbarItem

@injectable()
export class CustomProgressStatusBarItem extends ProgressStatusBarItem {
 @inject(BackgroundProcessService) private readonly backgroundProcessService: BackgroundProcessService;

    protected update(progressId: string | undefined): void {
        const message = progressId && this.messagesByProgress.get(progressId);
        if (!progressId || !message) {
            this.statusBar.removeElement(this.id);
            return;
        }
        const text = `$(refresh~spin) ${message}`;
        this.statusBar.setElement(this.id, {
            text,
            alignment: StatusBarAlignment.LEFT,
            priority: 1,
            tooltip: 'Show details',
             onclick: ()=> {
                 this.backgroundProcessService.togglePopover();
             },
        });
    }
}

But due to this change,the event generated on click of statusbar is pointerEvent which is not a MouseEvent. Am I doing something wrong or I need to use CommandId instead of onClick ?

github.com

eclipse-theia/theia/blob/64d193dcddc57dc40b32cc9976c5a4a68ab023ed/packages/core/src/browser/status-bar/status-bar.tsx#L175


}

protected createAttributes(entry: StatusBarEntry): React.Attributes & React.HTMLAttributes<HTMLElement> {
    const attrs: React.Attributes & React.HTMLAttributes<HTMLElement> = {};

    if (entry.command) {
        attrs.onClick = this.onclick(entry);
        attrs.className = 'element hasCommand';
    } else if (entry.onclick) {
        attrs.onClick = e => {
            if (entry.onclick && e instanceof MouseEvent) {
                entry.onclick(e);
            }
        };
        attrs.className = 'element hasCommand';
    } else {
        attrs.className = 'element';
    }

    if (entry.tooltip) {
        attrs.title = entry.tooltip;

tsmaeder · 9 May 2022 07:24

Hmh…first off: MouseEvent is an interface, but interfaces get erased in compilation. So how would this even work. Then: PointerEvent is a sub-interface of MouseEvent, so if the instanceof would work, it would be correct.

In conclusion, this looks like a bug to me, please open an issue. If you have an example, you can share, that would be super.

chakraborty-slx · 9 May 2022 10:39

Thanks @tsmaeder , I have filled an issue StatusBar onClick function not called with latest update v1.25.0 · Issue #11116 · eclipse-theia/theia (github.com)