TreeViewsMain missing part of VSCode api?

discobot · 25 October 2019 19:46

TreeView.reveal() is currently supported according to this doc:
https://che-incubator.github.io/vscode-theia-comparator/status.html

But apparently that is not the case. I have an extension where the reveal() currently works in VSCode but doesn’t seem to do much in Theia. Also, I was taking a look in the source code and looks like the selectionOptions are not being taken into account (select is never used, focus and expand are missing):

github.com

eclipse-theia/theia/blob/65d5925d450d529be45902b23f421d393211d38c/packages/plugin-ext/src/plugin/tree/tree-views.ts#L199


        treeDataProvider.onDidChangeTreeData((e: T) => {
            proxy.$refresh(treeViewId);
        });
    }
}

dispose(): void {
    this.toDispose.dispose();
}

async reveal(element: T, selectionOptions?: { select?: boolean }): Promise<void> {
    // find element id in a cache
    let elementId;
    this.nodes.forEach((el, id) => {
        if (Object.is(el, element)) {
            elementId = id;
        }
    });

    if (elementId) {
        return this.proxy.$reveal(this.treeViewId, elementId);

[original thread by Raphael Dos Santos]

akosyakov · 26 October 2019 06:06

Hi @santosr, unfortunately at the beginning we were accepting PRs stubbing VS Code apis. We are trying not to accept anymore such PRs, but ask for the proper implementation. Although it is not always possible.

akosyakov · 26 October 2019 06:07

For this case, could you please file an issue? PRs are welcomed as well.

akosyakov · 28 October 2019 05:31

opened https://github.com/eclipse-theia/theia/issues/6452 to track it

tsmaeder · 28 October 2019 09:18

@anton-kosyakov we should do a pass over the API implementation to find stubs and track them.

akosyakov · 29 October 2019 06:17

@tsmaeder it would be helpful if someone does it, but it is quite tedious to check whether each property of each interface is actually used, sometimes it seems to be used, i.e. someone even copied it and passed to the main process but then did not do anything with it big parts like file system provider and editor comment contributors should be tracked already

tsmaeder · 29 October 2019 08:32

Would running the VS Code API tests (https://github.com/eclipse-theia/theia/issues/4224) be sufficient to track down the stub implementations? Does it cover all API’s?

tsmaeder · 29 October 2019 10:44

@anton-kosyakov ?

akosyakov · 29 October 2019 15:02

I don’t know, it will catch some cases but I doubt that all will be covered