Update vscode default api version?

discobot · 2 September 2019 08:28

Can the default api version of vscode be updated to the latest (1.37.1) ?
Currently it’s configured in theia to be 1.33.1 and missing some new apis.

github.com

eclipse-theia/theia/blob/master/packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts#L22


* https://www.gnu.org/software/classpath/license.html.
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
********************************************************************************/

/* eslint-disable @typescript-eslint/no-explicit-any */

import * as theia from '@theia/plugin';
import { BackendInitializationFn, PluginAPIFactory, Plugin, emptyPlugin } from '@theia/plugin-ext';

export const VSCODE_DEFAULT_API_VERSION = '1.44.0';

/** Set up en as a default locale for VS Code extensions using vscode-nls */
process.env['VSCODE_NLS_CONFIG'] = JSON.stringify({ locale: 'en', availableLanguages: {} });
process.env['VSCODE_PID'] = process.env['THEIA_PARENT_PID'];

const pluginsApiImpl = new Map<string, typeof theia>();
const plugins = new Array<Plugin>();
let defaultApi: typeof theia;
let isLoadOverride = false;
let pluginApiFactory: PluginAPIFactory;

Are there any restriction doing so?

[original thread by DoroNahari]

akosyakov · 2 September 2019 08:56

@dna yes, please file a PR

akosyakov · 2 September 2019 08:56

there is also env variable to work it around

akosyakov · 2 September 2019 08:58

btw what is the motivation?

akosyakov · 2 September 2019 08:58

you can also specify vscode api version on start, see https://github.com/theia-ide/theia/pull/4774#issue-266298249

discobot · 4 September 2019 08:41

[DoroNahari]

There is new file system api since 1.36 https://code.visualstudio.com/updates/v1_36#_vscodeworkspacefs

akosyakov · 4 September 2019 09:11

ok, i thought you want to use some extension which require 1.37.1? anyway please do a PR we are ok to be aligned with latest version

discobot · 4 September 2019 10:17

[DoroNahari]

Ok, I guess some adjustments need to be made for this new api to work?

akosyakov · 4 September 2019 10:54

@dna there are usually 2 issues, an extension cannot start because version is not supported yet or api is not implemented. Just bumping up a version will solve the first one. In order to implement a new API, we need a separate PR.